Skip to content

v0.9.2: resource dropdown in org view, new library posts, removed unnecessary tests - #8303

Merged
waleedlatif1 merged 17 commits into
mainfrom
staging
Sep 26, 2026
Merged

waleedlatif1 merged 17 commits into
mainfrom
staging

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Sep 25, 2026 •

Copy link
Copy Markdown
Collaborator

waleedlatif1 and others added 7 commits September 25, 2026 09:03
…up (#8295)

* chore(tests): remove low-signal tests and consolidate the testing setup

* fix(tests): address review — shared disposable-DB guard, optional Redis suite, restored client-info wire contract
Co-authored-by: Sim Pi Agent <pi@sim.ai>
Co-authored-by: Sim Pi Agent <pi@sim.ai>
…ource menu (#8302)

* improvement(chat): nest folders inside their resources in the org resource menu

* fix(chat): show a loading row while a workspace resource menu hydrates
@waleedlatif1
waleedlatif1 requested a review from a team as a code owner September 25, 2026 18:16
@vercel

vercel Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Sep 26, 2026 3:01am UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 3000 files

Note: This PR contains a large number of files. cubic selects up to 200 of the highest-priority eligible files for this review, so some files may not have been reviewed.
Tip: instead of fixing issues one by one fix them all with cubic

Re-trigger cubic

Comment thread apps/sim/lib/mothership/billing/service-store.integration.ts Outdated
Comment thread .agents/skills/test-audit/SKILL.md
Comment thread apps/sim/lib/knowledge/application/github-installations.integration.ts Outdated
Comment thread .cursor/rules/sim-testing.mdc Outdated
Comment thread apps/sim/app/api/auth/oauth2/token/route.integration.ts
Comment thread apps/sim/lib/knowledge/__integration__/github-member.integration.ts Outdated
@greptile-apps

greptile-apps Bot commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 4/5

[High risk] Upgrades test framework and removes many unit tests across the codebase.

The PR appears mergeable after the TypeScript requirement is satisfied; retaining the focused MCP regression check would also protect an otherwise untested boundary.

Findings

  1. P2 Untyped test fixture ▶
  2. P2 Missing same-author secret check ▶

Summary

The PR reorganizes the organization chat resource picker into workspace submenus, updates library articles, and substantially consolidates test suites and their integration-test infrastructure.

  • Adds folder-aware workspace resource menus while preserving cross-workspace search.
  • Moves infrastructure tests to a disposable-database integration mode and removes numerous unit tests.
  • Updates testing guidance and upgrades Vitest.

Reviews (1) · Last reviewed commit: "improvement(chat): nest folders inside t..."

Comment thread apps/sim/executor/handlers/condition/condition-handler.test.ts Outdated
Comment thread apps/sim/app/api/mcp/serve/[serverId]/route.test.ts
* fix(slack): make manifest copying direct and order setup steps

* fix(slack): preserve manual setup and accessible credential fields

* fix(slack): prefill app creation and validate bot names

* fix(slack): reject oversized app creation links
* fix(trigger): exclude integration test files from task discovery

* fix(trigger): cover tsx and jsx test files in task discovery ignores
* fix(ui): compact crowded tabs and layer native browser overlays

* fix(ui): preserve native occlusion during snapshot refresh

* chore(tests): keep native refresh coverage at the Electron boundary
* fix(files): keep the shared markdown parser editor unmounted

* fix(files): serialize without deferred work and guard it with a regression test

* fix(files): destroy every editor a markdown paste test mounts
… @sim/testing mocks, check:test-patterns, lean agent docs (#8309)

* chore(tests): consolidate test patterns — shared Vitest base, central @sim/testing mocks, check:test-patterns, lean agent docs

* fix(tests): discover central mocks from their declarations and accept the async-import form

* fix(tests): address review — mock fidelity, docs, and guards

* docs(tests): restore the heavy-graph, global-mock and permanent-implementation rules and small doc pointers
…t chat tag a whole workspace (#8310)

* feat(chat): resolve org-chat mentions in their owner workspace and let chat tag a whole workspace

* fix(chat): keep a copied org resource chip's owner workspace and cover each owned kind

* fix(chat): paste a chip link with a malformed owner as plain text

* test(chat): assert org mention resolution by outcome, not mock calls

* test(mothership): centralize the chat workspace-context mock and assert its control route by outcome
* improvement(search): keep sources inline and show document icons

* feat(search): add private history and responsive result states

* fix(search): revalidate recent sources and polish state transitions

* fix(search): keep private history independent of indexed search
…rch and document-decided workspace retrieval (#8314)

- Move indexed organization search under lib/sim-search/indexed, dormant behind the single isIndexedOrgSearchEnabled() gate, with a check:indexed-org-search-boundary audit keeping callers on its public entry
- Decide workspace knowledge base search on the document for every principal, so workspace retrieval never waits on the projector
- Remove the knowledge-async-projection, knowledge-projection-fill and knowledge-tin-keyword flags and their code paths
- Trim the projector to a single periodic sweep that releases workspace marks before deciding whether a pass is owed
- Remove per-source vector index builds
- Scope member sync and processing recovery to the indexed search path
- Remove dead code left behind by the consolidation
- Add an ops runbook and scripts for recovering and maintaining a dormant search index
@waleedlatif1
waleedlatif1 merged commit bcb348f into main Sep 26, 2026
71 of 72 checks passed

This branch was previously deployed

1 inactive deployment
Preview — 0dd4c8d8 Deployed Sep 26, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants